Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: <carry>: openshift: run e2e test from cloned repo #104

Merged
merged 3 commits into from
Jun 17, 2019
Merged

UPSTREAM: <carry>: openshift: run e2e test from cloned repo #104

merged 3 commits into from
Jun 17, 2019

Conversation

frobware
Copy link

Switch to running the e2e tests directly from the cloned repo:

https://github.com/openshift/cluster-api-actuator-pkg

as opposed to vendoring that repo.

frobware added 3 commits June 17, 2019 12:23
@frobware
UPSTREAM: <carry>: openshift: remove test/openshift/vendor
201abe7 
We're going to switch to running go get directly on the
cluster-api-actuator-pkg.
@frobware
UPSTREAM: <carry>: openshift: add test/openshift/hack scripts
a8df8f9 
Copied e2e.sh from:

    https://github.com/openshift/cluster-autoscaler-operator

repo.
@frobware
UPSTREAM: <carry>: openshift: update e2e test invocation
35e7c76 
Run e2e tests directly from cloned cluster-api-actuator-pkg repo.
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 17, 2019
bison
bison approved these changes Jun 17, 2019
View reviewed changes
Copy link

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2019
@openshift-merge-robot openshift-merge-robot merged commit c02aa39 into openshift:master Jun 17, 2019
@frobware frobware mentioned this pull request Jun 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison bison approved these changes

@asalkeld asalkeld Awaiting requested review from asalkeld

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@bison bison

Labels
lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frobware @bison @openshift-ci-robot @openshift-merge-robot